[#STS-315] MockHttpServletRequest.addHeader and getHeader do not work with upper-case header names

Description

addHeader(name, value) calls toLowerCase() before saving the header in the Set, but getHeader(name) does not check if the supplied parameter is lowercase or not.

The patch supplied provides both the unittest and the fix.

Description

addHeader(name, value) calls toLowerCase() before saving the header in the Set, but getHeader(name) does not check if the supplied parameter is lowercase or not. The patch supplied provides both the unittest and the fix.

Show »

[ Permlink | « Hide ]

Renaud Bruyeron [01/Dec/06 07:35 AM]

Provides a simple test case that shows that if you do MockHttpServletRequest.addHeader("User-Agent", "something") then getHeader("User-Agent") returns null.

The fix simply tries again after toLowerCase() if the first attempt returns null.

[ Permlink | « Hide ]

Ben Gunter [03/Mar/07 09:11 PM]

I opted to just convert the header name to lower-case before looking it up. The patch for the test class was applied as-is.