History | Log In     View a printable version of the current page. Get help!  
Issue Details (XML | Word)

Key: STS-305
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Ben Gunter
Reporter: Ben Gunter
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Stripes

FormTag should check for null action and null binding

Created: 09/Nov/06 06:30 AM   Updated: 17/Mar/07 01:10 PM
Component/s: Tag Library
Affects Version/s: Release 1.4.1
Fix Version/s: Release 1.4.3


 Description  « Hide
I did something admittedly dumb and created a <stripes:form> without setting either the binding or action attributes on the tag. This resulted in Stripes calling ServletRequest.getAttribute() with a null argument, which threw a NPE at FormTag.java, line 305. I had to look at the source code to figure out what was wrong. Stripes should check for this condition and throw a more informative exception if it occurs.



 All   Comments   Change History      Sort Order:
Ben Gunter [16/Nov/06 06:31 AM]
It's actually one of 'action' or 'beanclass' that is required. I added a sanity check to doStartTag() to check for this condition.